Fix invalid skill ids in party tab source #8211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
LocalIdentity
approved these changes
Aug 31, 2024
LocalIdentity
merged commit a08b6a0
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8060
Sorry for now seeing this when the issue was made, this now checks if a skill is a valid skill, if not it replaces it with the name of the aura applying it if valid, otherwise replaces it with a text source to prevent crashes (note this makes source show up as empty instead of crashing, eg malformed purity of lightning)
This shouldnt be an issue for any current exports but is for older exports, and likely will be an issue in future (also helps with user edits xmls)