Disable "gain when hit" for builds which cannot survive unlucky hits #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables "gain when hit" (eg gain on block) regardless of config, if the build cannot survive a hit from the enemy.
Not the biggest fan of this solution, as it causes a huge spike in EHP for certain builds once they cross that threshold, there is also debate if this number should be higher to intensive people to get higher max hit, or even if we should add a ramping function to the amount of gain on block depending on how likely they are to survive, eg if they can survive a normal hit but not a crit, only apply 70% gain on block, and if they can also survive a crit then apply 100%, and between those do a ramp function.
Out of 100 builds I have looked at for this, it applies to 6 anyway (vs guardian boss config).