Revert "No need for CPP flags on linux" #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts #50, which I have noticed just now.
Support for CPPFLAGS was originally added by me in #39, and then removed by @hmaarrfk’s #50 with the description “no need for CPP flags on linux”.
However, that was incorrect. There is a need for CPPFLAGS on Linux, specifically for example for Debian packaging, which passes additional hardening flags, as my original #39 mentioned.
I verified this just now.
With CPPFLAGS, the build output is:
Without CPPFLAGS, the build output is:
Note that
-D_FORTIFY_SOURCE=2
is missing when CPPFLAGS is not specified.