Fixed merging. #15
Open
Fixed merging. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing due to the addition of the |
pvshvp-oss
requested changes
May 8, 2024
There was a problem hiding this comment.
Why the resolver that is no longer the default in newer editions?
There was a problem hiding this comment.
Using the newer resolver causes extism to stop being resolved
There was a problem hiding this comment.
Did you find any documentation on why this has to be done? It seems strange
There was a problem hiding this comment.
Perhaps the name could be a bit more clear to distinguish from an actual plugin. Just an opinion
There was a problem hiding this comment.
Paxy-plugin functions like any user plugin i.e. it is a ln actual plugin
There was a problem hiding this comment.
What is this plugin for? And why is it within the Paxy repository?
* added basic remove repo function * cleaner error reporting * semver submodule to dependency * merge bug * refactroed to use macro --------- Co-authored-by: Ishaan Subramanya <whthownothing@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of test failures due to incorrect imports and misplaced functions.
NOTE: paxy-plugin is not yet functional