Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TA-3384]: Refactor project structure #29

Merged
merged 16 commits into from
Oct 3, 2024
Merged

[TA-3384]: Refactor project structure #29

merged 16 commits into from
Oct 3, 2024
+1,593 −1,644

Conversation

GuillemGarciaDev
Copy link

[TA-3384]: Refactor project structure

This PR aims to refactor the project structure for a better future project scaling. It removes utils packages, split package responsabilities and add ci/cd rules for security checks.

Changes

  • Add github actions workflow for linting and testing
  • split models subpackages
  • splitclient package into implementation packages: rpc and websocket.
  • replace test package with testutil

@notion-workspace Notion Workspace
Copy link

Refactor project structure

@GuillemGarciaDev GuillemGarciaDev added pkg:xrpl xrpl package pkg:address-codec address-codec package pkg:binary-codec binary-codec package labels Oct 2, 2024
florent-uzio
florent-uzio approved these changes Oct 3, 2024
View reviewed changes
Copy link

@florent-uzio florent-uzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the refactor!
I left one suggestion.

xrpl/ledger/account_root.go Outdated Show resolved Hide resolved
@GuillemGarciaDev GuillemGarciaDev merged commit 7756d58 into v1.x.x Oct 3, 2024
3 checks passed
@GuillemGarciaDev GuillemGarciaDev deleted the refactor/packages/setup branch October 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florent-uzio florent-uzio florent-uzio approved these changes

@AgustinMJ AgustinMJ Awaiting requested review from AgustinMJ

Assignees
No one assigned
Labels
pkg:address-codec address-codec package pkg:binary-codec binary-codec package pkg:xrpl xrpl package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillemGarciaDev @florent-uzio