-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA-3386]: NewWalletFromMnemonic #30
base: v1.x.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Nice job!
@@ -3,7 +3,7 @@ on: | |||
push: | |||
branches: [ main ] | |||
pull_request: | |||
branches: [ main, 'v*' ] | |||
branches: [ '**' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does **
mean?
|
||
return &Wallet{ | ||
PublicKey: pubKey, | ||
PrivateKey: fmt.Sprintf("00%s", privKey), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this generation from a mnemonic only generates a secp256k1 key ? Is it possible to generate an ed25519 also ?
[TA-3386]: NewWalletFromMnemonic
This PR aims to add a new wallet method
NewWalletFromMnemonic
method.Changes
address-codec
keypairs
xrpl
NewWalletFromMnemonic