CI bug for main/release #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBolten
reviewed
Jun 30, 2023
| - name: Make upload dir | ||
| run: mkdir -p ${{ env.UPLOAD_DIR }} | ||
| - name: build-and-push | ||
| uses: docker/build-push-action@v2 | ||
| with: | ||
| file: Dockerfile | ||
| push: false | ||
| tags: steward:prebuilt | ||
| push: ${{ github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
I suppose my main question here is: do we need to push to Docker at all for steward and hardhat images in our CI workflows? Couldn't we just build the steward and hardhat docker images as artifacts and remove the push aspect entirely?
There was a problem hiding this comment.
my thinking was we wanted the steward:main tag to get pushed when merging to main?
afa hardhat, maybe not so much
There was a problem hiding this comment.
We don't really need to publish any docker images unless something else needs to pull them. Steward as a repo is effectively a leaf node in the dependency tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.