Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balancer pool adaptor #216

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Balancer pool adaptor #216

merged 5 commits into from
Aug 16, 2023

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Jul 18, 2023

No description provided.

@cbrit cbrit temporarily deployed to CI July 18, 2023 01:38 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 01:38 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 01:38 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 01:38 — with GitHub Actions Inactive
EricBolten
EricBolten reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions.

proto/adaptors/balancer/balancer_pool.proto Outdated Show resolved Hide resolved
steward/src/cellars/adaptors/aave_v3.rs Show resolved Hide resolved
proto/adaptors/balancer/balancer_pool.proto Show resolved Hide resolved
steward/src/cellars/adaptors/balancer_pool.rs Outdated Show resolved Hide resolved
steward/src/cellars/adaptors/balancer_pool.rs Outdated Show resolved Hide resolved
steward/src/cellars/adaptors/balancer_pool.rs Outdated Show resolved Hide resolved
steward/src/cellars/adaptors/balancer_pool.rs Outdated Show resolved Hide resolved
@cbrit cbrit temporarily deployed to CI July 18, 2023 21:37 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 21:37 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 21:37 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 18, 2023 21:37 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 27, 2023 21:09 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 27, 2023 21:09 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 27, 2023 21:09 — with GitHub Actions Inactive
@EricBolten
Copy link
Contributor

Looks like there are a couple CI issues here as well.

@cbrit cbrit temporarily deployed to CI August 16, 2023 19:42 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 19:42 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 19:42 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 19:42 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 20:22 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 20:22 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 20:22 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 16, 2023 20:22 — with GitHub Actions Inactive
EricBolten
EricBolten approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit 48de065 into 3.x-main Aug 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBolten EricBolten EricBolten approved these changes

@josephterrigno josephterrigno Awaiting requested review from josephterrigno

@crispymangoes crispymangoes Awaiting requested review from crispymangoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrit @EricBolten