Support flashloans in Balancer adaptor API #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrit
requested review from
EricBolten,
51N84D,
josephterrigno and
crispymangoes
EricBolten
reviewed
Oct 12, 2023
| // Represents function calls to the MorphoAaveV3DebtToken V1 | ||
| MorphoAaveV3DebtTokenAdaptorV1Calls morpho_aave_v3_debt_token_v1_calls = 23; | ||
| // Represents function calls to the BalancerPoolAdaptor V1 | ||
| BalancerPoolAdaptorV1Calls balancer_pool_v1_calls = 24; |
There was a problem hiding this comment.
BalancerPoolAdaptorV1Calls can be removed as we are not allowed to call it in the Flashloan due to reentrancy
There was a problem hiding this comment.
this would be true for aave v3's flash loan adaptor calls too right? remove its own calls from the set?
EricBolten
reviewed
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.