Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace steward registry info with pubsub info #261

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented May 28, 2024

Summary by CodeRabbit

  • Documentation
    • Updated instructions for providing the Certificate Authority (CA) on-chain.
    • Added detailed steps for creating or updating a Subscriber in the Steward registry.
    • Included guidance on using the sommelier CLI and steward CLI for adding subscribers.

@cbrit cbrit requested a review from zmanian May 28, 2024 13:34
Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

The recent changes to the documentation focus on how to provide the Certificate Authority (CA) on-chain by creating or updating a Subscriber in the Steward registry. This involves using either the sommelier CLI or the steward CLI to add a subscriber, with detailed instructions provided for both methods. The updates aim to clarify the process and ensure users can effectively register their CA on the Sommelier chain.

Changes

File Change Summary
docs/04-GeneratingCertificates.md Updated to include instructions for providing the CA on-chain by creating/updating a Subscriber. Added details on the sommelier and steward CLI usage for adding subscribers.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant SommelierCLI
    participant StewardCLI
    participant StewardRegistry

    User->>SommelierCLI: Add Subscriber
    SommelierCLI->>StewardRegistry: Register Subscriber with CA
    StewardRegistry-->>SommelierCLI: Confirmation

    User->>StewardCLI: Add Subscriber
    StewardCLI->>StewardRegistry: Register Subscriber with CA
    StewardRegistry-->>StewardCLI: Confirmation
Loading

This diagram illustrates the process of adding a subscriber using either the sommelier CLI or the steward CLI, interacting with the Steward registry to register the CA and receive confirmation.


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6a4c687 and ea66840.
Files selected for processing (1)
  • docs/04-GeneratingCertificates.md (1 hunks)
Additional Context Used
LanguageTool (4)
docs/04-GeneratingCertificates.md (4)

Near line 5: You might be missing the article “the” here.
Context: ...o-way trust must be established between Steward and the Strategy Provider client for ea...
Rule ID: AI_EN_LECTOR_MISSING_DETERMINER_THE


Near line 33: The adverb “publically” isn’t commonly used. Consider using the shorter “publicly”.
Context: ...r the domain name where Steward will be publically hosted. At least one of these MUST be s...
Rule ID: PUBLICALLY


Near line 33: You might be missing the article “the” here.
Context: .... At least one of these MUST be set for Steward to start up with the certificate. Pleas...
Rule ID: AI_EN_LECTOR_MISSING_DETERMINER_THE


Near line 60: After the expression ‘for example’ a comma is usually used.
Context: ...configured for your Steward server. For example steward.example.com:5734.
Rule ID: COMMA_FOR_EXAMPLE

Markdownlint (3)
docs/04-GeneratingCertificates.md (3)

62: Expected: 1; Actual: 2
Multiple consecutive blank lines


17: null
Fenced code blocks should have a language specified


39: null
Fenced code blocks should have a language specified

Additional comments not posted (1)
docs/04-GeneratingCertificates.md (1)

45-60: Update section title and content to reflect new functionality.

The updated section title and content clearly outline the new process for providing a CA on-chain by creating or updating a Subscriber. This aligns with the PR's objective to replace steward registry info with pubsub info. The instructions are clear and provide direct commands and links for further steps.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zmanian zmanian merged commit fe82aa2 into main May 28, 2024
5 of 6 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (5)
docs/04-GeneratingCertificates.md (5)

Line range hint 5-5: Consider adding the missing article "the".

- Two-way trust must be established between Steward and Strategy Provider client for each request.
+ Two-way trust must be established between Steward and the Strategy Provider client for each request.

Line range hint 33-33: Correct the usage of "publically" to "publicly".

- The final two prompts will ask for the domain name where Steward will be publically hosted.
+ The final two prompts will ask for the domain name where Steward will be publicly hosted.

Line range hint 33-33: Add the missing article "the".

- At least one of these MUST be set for Steward to start up with certificate.
+ At least one of these MUST be set for Steward to start up with the certificate.

Line range hint 62-62: Remove extra blank lines.

Please ensure to remove the extra blank lines at the end of the document to maintain a clean and professional format.


Line range hint 17-17: Specify language for code blocks.

Please specify the language for the fenced code blocks to enhance readability and syntax highlighting. For example, use ```bash for Bash scripts.

Also applies to: 39-39

8. Provide your CA to the Strategy Provider

Add your information to the [Steward Registry](https://github.com/peggyjv/steward-registry) by following the steps outlined in the README there.
As a reminder, your "push URL" is the combination of the fully qualified domain name of your production Steward instance and the port configured for your Steward server. For example `steward.example.com:5734`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma after "for example".

- For example `steward.example.com:5734`.
+ For example, `steward.example.com:5734`.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
As a reminder, your "push URL" is the combination of the fully qualified domain name of your production Steward instance and the port configured for your Steward server. For example `steward.example.com:5734`.
As a reminder, your "push URL" is the combination of the fully qualified domain name of your production Steward instance and the port configured for your Steward server. For example, `steward.example.com:5734`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants