WIP - Initial go request builder package #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe latest updates primarily introduce advanced builders in the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (2)
Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+41
to
+65
| // CallOnAdaptor adds call data for the CallOnAdaptor function to the builder | ||
| func (cdb *CellarCallBuilder) CallOnAdaptor(adaptorCall *steward_proto.AdaptorCall) *CellarCallBuilder { | ||
| // search functionCalls for type steward_proto.CellarV2_5_FunctionCall_CallOnAdaptor and if | ||
| // it already exists, append to CallOnAdaptor.Data instead of creating a new CallOnAdaptor struct | ||
| found := false | ||
| for _, call := range cdb.functionCalls { | ||
| if call.GetCallOnAdaptor() != nil { | ||
| found = true | ||
| call.GetCallOnAdaptor().Data = append(call.GetCallOnAdaptor().Data, adaptorCall) | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if !found { | ||
| cdb.functionCalls = append(cdb.functionCalls, &steward_proto.CellarV2_5_FunctionCall{ | ||
| Function: &steward_proto.CellarV2_5_FunctionCall_CallOnAdaptor { | ||
| CallOnAdaptor: &steward_proto.CellarV2_5_CallOnAdaptor{ | ||
| Data: []*steward_proto.AdaptorCall{adaptorCall}, | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| return cdb | ||
| } |
There was a problem hiding this comment.
Optimize the addition of function calls.
The method CallOnAdaptor checks if a specific type of function call exists before adding a new one. This could be optimized using a map for quicker lookups.
- found := false
- for _, call := range cdb.functionCalls {
- if call.GetCallOnAdaptor() != nil {
- found = true
- call.GetCallOnAdaptor().Data = append(call.GetCallOnAdaptor().Data, adaptorCall)
- break
- }
- }
+ if call, exists := cdb.functionCallMap["CallOnAdaptor"]; exists {
+ call.GetCallOnAdaptor().Data = append(call.GetCallOnAdaptor().Data, adaptorCall)
+ } else {
+ cdb.functionCalls = append(cdb.functionCalls, &steward_proto.CellarV2_5_FunctionCall{
+ Function: &steward_proto.CellarV2_5_FunctionCall_CallOnAdaptor {
+ CallOnAdaptor: &steward_proto.CellarV2_5_CallOnAdaptor{
+ Data: []*steward_proto.AdaptorCall{adaptorCall},
+ },
+ },
+ })
+ }This change introduces a map to track existing function calls, improving the efficiency of lookups and additions.
Committable suggestion was skipped due to low confidence.
zmanian
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores