Skip to content

Commit

Permalink
Fix codacy flagged issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Ulthran committed May 15, 2024
1 parent 8de6918 commit 5875284
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
15 changes: 6 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
### Summary :memo:
_Write an overview about it._


_Write an overview about it._

### Details
_Describe more what you did on changes._


_Describe more what you did on changes._

### Bugfixes :bug: (delete if didn't have any)



### Checks

If this is for a release:
- [ ] I have updated the version number in `src/dnabc/__init__.py`
- [ ] I have updated the README with any appropriate documentation
- [ ] I have updated `tests` with any appropriate tests

- [ ] I have updated the version number in `src/dnabc/__init__.py`
- [ ] I have updated the README with any appropriate documentation
- [ ] I have updated `tests` with any appropriate tests
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ test = ["pytest", "pytest-cov"]
"Source" = "https://github.com/PennChopMicrobiomeProgram/dnabc"

[project.scripts] # Optional
"dnabc.py" = "dnabclib.main:main"
"split_samplelanes.py" = "dnabclib.split_samplelanes:main"
"dnabc.py" = "dnabc.main:main"
"split_samplelanes.py" = "dnabc.split_samplelanes:main"

[build-system]
requires = ["setuptools>=61.0.0", "wheel"]
Expand Down
2 changes: 1 addition & 1 deletion src/dnabc/assigner.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def __init__(self, samples, mismatches=0, revcomp=True):
self.samples = samples
if mismatches not in self.allowed_mismatches:
raise ValueError(
"Only %s mismatches allowed (got %s)" % (allowed_mismatches, mismatches)
"Only %s mismatches allowed (got %s)" % (self.allowed_mismatches, mismatches)
)
self.mismatches = mismatches
self.revcomp = revcomp
Expand Down
1 change: 1 addition & 0 deletions src/dnabc/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import gzip
import os

from . import __version__

Check notice on line 5 in src/dnabc/main.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/dnabc/main.py#L5

'.__version__' imported but unused (F401)
from .writer import PairedFastqWriter
from .sample import load_sample_barcodes
from .seqfile import SequenceFile
Expand Down

0 comments on commit 5875284

Please sign in to comment.