Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address remaining issues flagged by ruff #1318

Open
tsalo opened this issue Nov 5, 2024 · 0 comments
Open

Address remaining issues flagged by ruff #1318

tsalo opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.

Comments

@tsalo
Copy link
Member

tsalo commented Nov 5, 2024

I ended up ignoring these issues because I just wanted to merge #1312, but I do want to fix them at some point. The big ones are:

  1. Use of assert statements throughout the package (I used a lot!)
  2. Use of os.system, subprocess.popen, etc.
@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Nov 5, 2024
@tsalo tsalo self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

No branches or pull requests

1 participant