Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if atlas affines don't match across participants #1075

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 4, 2024

Closes #1069. This is a temporary solution, until XCP-D starts using the NiPreps resampler tool to just resample preprocessing derivatives to a requested space and resolution (see #1076).

Changes proposed in this pull request

  • Add a step in copy_atlas that checks if the new resampled NIfTI atlas's affine matches the existing one's. If it doesn't match, then XCP-D will raise a ValueError.
  • Convert copy_atlas to an interface (CopyAtlas).

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (f9a597d) to head (b483299).
Report is 113 commits behind head on main.

Files Patch % Lines
xcp_d/interfaces/bids.py 95.83% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
+ Coverage   82.33%   82.43%   +0.10%     
==========================================
  Files          48       48              
  Lines        5897     5916      +19     
  Branches      796      798       +2     
==========================================
+ Hits         4855     4877      +22     
+ Misses        839      837       -2     
+ Partials      203      202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 9fe6603 into PennLINC:main Mar 12, 2024
20 checks passed
@tsalo tsalo deleted the native-space-error branch March 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing native-resolution runs with different voxel sizes will fail
1 participant