Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow space-fsaverage for sphere files #1217

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 27, 2024

Closes none, but relates to nipreps/fmriprep@ea65196, nipreps/smriprep#446, and nipreps/nibabies#368. This will probably take effect at Nibabies 24.0.0 and fMRIPrep 24.0.2.

Changes proposed in this pull request

  • Accept either no space entity (old/current versions for fMRIPrep and nibabies) or space-fsaverage (upcoming versions of fMRIPrep and nibabies) for surface spheres used in the anatomical workflow.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Jul 27, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (18e39a4) to head (e031dda).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1217   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files          54       54           
  Lines        7065     7065           
  Branches     1027     1027           
=======================================
  Hits         5955     5955           
  Misses        850      850           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit f8d2345 into PennLINC:main Jul 28, 2024
21 checks passed
@tsalo tsalo deleted the fsaverage-sphere branch July 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant