Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NIfTI-surface connection #1284

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 8, 2024

Closes none, but addresses an issue reported in https://neurostars.org/t/xcp-d-some-connections-were-not-found/30667.

This bug arises when users (1) provide derivatives with mesh files, (2) enable abcc-qc, and (3) enable NIfTI processing. Because the mesh files are available and abcc-qc is enabled, the surface-processing workflow is enabled (though without normalization to fsLR because --warp-surfaces-native2std isn't enabled), but the BOLD post-processing workflow doesn't use the post-processed surfaces.

This bug should affect versions 0.8.0 - 0.10.rc1, although it might affect earlier versions.

Changes proposed in this pull request

  • Only pass midthickness files to the BOLD post-processing workflow if CIFTI processing is enabled.

midthickness files should not be passed along to the BOLD postprocessing workflow when NIfTI processing is enabled
@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Oct 8, 2024
@tsalo
Copy link
Member Author

tsalo commented Oct 8, 2024

Bug successfully reproduced:

E               Exception: Some connections were not found
E               Module postprocess_0_wf has no input called inputnode.lh_midthickness
E               
E               Module postprocess_0_wf has no input called inputnode.rh_midthickness

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (63641d0) to head (d44f337).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files          59       59           
  Lines        7360     7360           
  Branches     1136     1136           
=======================================
  Hits         5800     5800           
  Misses       1267     1267           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit c26499b into PennLINC:main Oct 8, 2024
23 checks passed
@tsalo tsalo deleted the fix-nifti-surface-connection branch October 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant