-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMB] Allow force to disable SMBv1 #523
Conversation
b58133a
to
1b7dbe3
Compare
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Smbv3 you mean no ? |
For what would you need it though? |
could solve this kind of issue |
Fair enough, sounds good |
Yes, so what should we call to the new args, or |
b821e2e
to
d33f164
Compare
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Added my comments, if a user decide to use the --no-smbv1 then is normal to return None on the smbv1 info since the user don't want to check smbv1 (can be related to other thing than the shares :) |
Got you
OK, just reverted that changed |
Description
Allow force to disable smbv1 in smb connection
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
nxc smb 127.0.0.1 -u a -p a --no-smbv1 --shares
Screenshots (if appropriate):
Checklist:
poetry run python -m ruff check . --preview
, use--fix
to automatically fix what it can)