Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and simplify MSWin32 colorization #54

Closed
wants to merge 5 commits into from
Closed

fix and simplify MSWin32 colorization #54

wants to merge 5 commits into from

Commits on Sep 11, 2016

  1. fix/improve color handling for MSWin32 platforms 

    + rationale: using Win32::Console::ANSI simplifies the code and improves Win32 outputs

- simplified usage ~ Win32::Console::ANSI is fire-and-forget
  - once loaded, use Term::ANSIColor without regard for platform
- fixes incorrect color 'reset' behavior
  - Win32::Color::ANSI resets correctly to the prior default color attribute set
  - bug due to incorrect assumption that LIGHTGRAY on BLACK are always the default color attributes
- fixes [GH#26](Perl-Toolchain-Gang#26)
  - Win32::Console::ANSI works for all output (no tie to a specific output handle)
  - [PR#34](Perl-Toolchain-Gang#34) is no longer needed
    @rivy
    rivy committed Sep 11, 2016
    Configuration menu
    Copy the full SHA
    d4c7cc5 View commit details
    Browse the repository at this point in the history

  2. remove IS_WIN32 platform test for color from prove 

    + rationale: platform dependencies are handled elsewhere/elsewhen by the test harness

- enables default use of color on 'MSWin32' systems
    @rivy
    rivy committed Sep 11, 2016
    Configuration menu
    Copy the full SHA
    bd6af7d View commit details
    Browse the repository at this point in the history

  3. minor documentation correction for TAP::Formatter::Color

    @rivy
    rivy committed Sep 11, 2016
    Configuration menu
    Copy the full SHA
    1a1bd5a View commit details
    Browse the repository at this point in the history

  4. minor documentation correction for prove

    @rivy
    rivy committed Sep 11, 2016
    Configuration menu
    Copy the full SHA
    4789cca View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. clarify use of Term::ANSIColor::color() in TAP::Formatter::Color

    @rivy
    rivy committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    279e44f View commit details
    Browse the repository at this point in the history