Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --no-cache and better permissions for user #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miracle091
Copy link

added --no-cache option and changed the removed directory to only /tmp/ better permissions for tor user, the default one is enough to be safe changed CMD to ENTRYPOINT, it's just for standarization

added --no-cache option and changed the removed directory to only /tmp/
better permissions for tor user, the default one is enough to be safe
changed CMD to ENTRYPOINT, it's just for standarization
@PeterDaveHello
Copy link
Owner

@miracle091 thanks for your contribution, looks like the image build process is broken, needs your fixes applied.

Copy link
Owner

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image built failed:

Step 6/10 : COPY --chown=tor torrc /etc/tor/

unable to convert uid/gid chown string to host mapping: can't find gid for group tor: no such group: tor


HEALTHCHECK --timeout=10s --start-period=60s \
CMD curl --fail --socks5-hostname localhost:9150 -I -L 'https://www.facebookwkhpilnemxj7asaniu7vnjjbiltxjqhye3mhbshg7kx5tfyd.onion/' || exit 1

USER tor
EXPOSE 8853/udp 9150/tcp

CMD ["/usr/bin/tor", "-f", "/etc/tor/torrc"]
ENTRYPOINT ["/usr/bin/tor", "-f", "/etc/tor/torrc"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be changed in this commit / pull request.

rm -rf /var/cache/apk/* && \
apk -v add --no-cache tor@edge obfs4proxy@edge curl && \
chown -R tor /var/lib/tor/ && \
rm -rf /tmp/* && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be unrelated to the topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants