Skip to content

Commit

Permalink
studied state was not connected (openMetadataInitiative#60)
Browse files Browse the repository at this point in the history
* studied state was not connected

* test for unattached subject state
  • Loading branch information
Peyman-N authored Jun 19, 2024
1 parent 2aed68f commit 465880b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion bids2openminds/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ def create_subjects(subject_id, layout_df, layout, collection):
subject_state_dict[f"{subject}"] = state_cache_dict
subject_cache = omcore.Subject(
lookup_label=f"{subject_name}",
internal_identifier=f"{subject_name}"
internal_identifier=f"{subject_name}",
studied_states=state_cache
)
subjects_dict[f"{subject}"] = subject_cache
subjects_list.append(subject_cache)
Expand Down
3 changes: 3 additions & 0 deletions test/test_bids_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ def test_example_datasets(dataset_label, dataset_subject_number, dataset_subject
files_number = 0
file_bundles_number = 0
behavioral_protocol_number = 0
subject_state_number_besed_on_subject = 0

for item in c:
if item.type_ == "https://openminds.ebrains.eu/core/Subject":
subject_number += 1
subject_state_number_besed_on_subject += len(item.studied_states)
if item.type_ == "https://openminds.ebrains.eu/core/SubjectState":
subject_state_number += 1
if item.type_ == "https://openminds.ebrains.eu/core/Person":
Expand All @@ -44,6 +46,7 @@ def test_example_datasets(dataset_label, dataset_subject_number, dataset_subject

assert dataset_subject_number == subject_number
assert dataset_subject_state_number == subject_state_number
assert subject_state_number_besed_on_subject == subject_state_number, "There was a discrepancy between the total number of subject states and the subject states attached to subjects."
assert dataset_person_number == person_number
assert dataset_files_number == files_number
assert dataset_file_bundles_number == file_bundles_number
Expand Down

0 comments on commit 465880b

Please sign in to comment.