-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSSDK: redesign the contract query arguments orders, security updates, docs #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leechael
force-pushed
the
imp-jssdk-api-design
branch
from
May 18, 2023 11:44
bbfe7f4
to
55d9e00
Compare
Leechael
force-pushed
the
imp-jssdk-api-design
branch
3 times, most recently
from
June 13, 2023 10:33
cf6a757
to
5cc97e7
Compare
Leechael
force-pushed
the
imp-jssdk-api-design
branch
from
July 10, 2023 21:41
4f8099a
to
d0c21e4
Compare
Leechael
changed the title
Improve JS-SDK API Design for cluster
JSSDK: redesign the contract query arguments orders, security updates, docs
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose to continue evolving the design for JS-SDK.
options
in the next. This is a breaking change. Checkout follow up code snippet:We haven't handle the situation when no cluster has been registered on chain. Also, we haven't organize cluster information well, so we try to address that as well.
A nice to have goal that add more test cases.