Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRBv3: Add chain state check & stake update on first run of worker loop #1444

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Nexus2k
Copy link

@Nexus2k Nexus2k commented Nov 21, 2023

This PR adds a on-chain state check by comparing on-chain stake with configured stake and triggers a compute restart call when configured stake in PRB is higher than on-chain.

Any code contribution bounty appreciated to: 42GD3CtQUNhrDb7Yw6pNCMzJr6mZHb5ScGKoUv6XVeTeMJZa

@Nexus2k Nexus2k changed the title Add chain state check & stake update on first run of worker loop PRBv3: Add chain state check & stake update on first run of worker loop Nov 21, 2023
@h4x3rotab
Copy link
Contributor

Thanks for your contribution! We have assigned our engineer to review it ASAP. We will be happy to raise a tip from the treasury if it gets merged.

@nanometerzhu
Copy link
Contributor

Hi Nexus2k, sorry for late relay, I was busy on the pRB performance issue last week so I didn't review it yet. I will review it carefully in these two days and provide you feedback.

@Leechael
Copy link
Contributor

Leechael commented Dec 2, 2023

@Nexus2k Can we remove the cargo.lock update from this PR since it appears to be unrelated?

@Leechael
Copy link
Contributor

Leechael commented Dec 2, 2023

@Nexus2k I'm sorry for the misunderstanding. What I meant was to "revert the change on cargo.lock," not to "remove the file from the repo."

@Nexus2k Nexus2k force-pushed the feat/stake-update-and-restart branch from 980591e to b659cf0 Compare December 2, 2023 15:01
@Nexus2k
Copy link
Author

Nexus2k commented Dec 2, 2023

Got it, sorry. Cargo.lock changes reverted.

@Nexus2k
Copy link
Author

Nexus2k commented Dec 13, 2023

Any update?

@Leechael
Copy link
Contributor

@nanometerzhu @h4x3rotab

@h4x3rotab
Copy link
Contributor

Sorry for the late reply, as we were under heavy workload recently.

Thanks for the contribution and raising the problem and providing a solution. The solution is well received by the team. However, we have decided to re-implement it as a part of the refactor of the worker lifecycle management rather than a bit ad-hoc implementation.

@Nexus2k
Copy link
Author

Nexus2k commented Dec 23, 2023

Where can I find a branch for the refactor of the WLM?

@h4x3rotab
Copy link
Contributor

I believe it's not pushed yet. Currently the focus is to refactor the tx routing and broadcasting logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants