-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRBv3: Add chain state check & stake update on first run of worker loop #1444
base: master
Are you sure you want to change the base?
PRBv3: Add chain state check & stake update on first run of worker loop #1444
Conversation
Thanks for your contribution! We have assigned our engineer to review it ASAP. We will be happy to raise a tip from the treasury if it gets merged. |
Hi Nexus2k, sorry for late relay, I was busy on the pRB performance issue last week so I didn't review it yet. I will review it carefully in these two days and provide you feedback. |
@Nexus2k Can we remove the |
@Nexus2k I'm sorry for the misunderstanding. What I meant was to "revert the change on cargo.lock," not to "remove the file from the repo." |
980591e
to
b659cf0
Compare
Got it, sorry. Cargo.lock changes reverted. |
Any update? |
Sorry for the late reply, as we were under heavy workload recently. Thanks for the contribution and raising the problem and providing a solution. The solution is well received by the team. However, we have decided to re-implement it as a part of the refactor of the worker lifecycle management rather than a bit ad-hoc implementation. |
Where can I find a branch for the refactor of the WLM? |
I believe it's not pushed yet. Currently the focus is to refactor the tx routing and broadcasting logic. |
This PR adds a on-chain state check by comparing on-chain stake with configured stake and triggers a compute restart call when configured stake in PRB is higher than on-chain.
Any code contribution bounty appreciated to: 42GD3CtQUNhrDb7Yw6pNCMzJr6mZHb5ScGKoUv6XVeTeMJZa