Change for RFC-0078: Merkleized Metadata #1585
Conversation
…These fields have been included by RFC78 for signed extension
| ); | ||
| let extra = (era, Compact(nonce), Compact(tip)); | ||
| let extra = (era, Compact(nonce), Compact(tip), mode); |
There was a problem hiding this comment.
Is this backward compatible?
There was a problem hiding this comment.
The current version doesn't work anymore with the polkadot-felowship upgrade. To check, you can run the test with --ignored and --test-threads=1 options. The tests will fail on Shibuya. We also fail to connect
to Shiden and Astar.
This pr fixes the issue.
So it is not backward compatible with the previous nodes but I assume all nodes will be upgraded or are already upgraded (Shiden and Astar have been upgraded).
There was a problem hiding this comment.
So it is not backward compatible with the previous nodes but I assume all nodes will be upgraded or are already upgraded (Shiden and Astar have been upgraded).
Sounds OK to me.
|
Thank you so much! Does this PR also include the universal Ledger app support? |
Indeed |
Add new fields (
mode+metadata_hash) when submitting a transaction.These fields have been included by RFC78 for signed extension.
mode: Included in the extrinsic. Themodeis either0which means to not include themetadata_hashin the signed data or themodeis1to include themetadata_hashin V1.metadata_hash: Included in the signed data. Depending on themodethe value is eitherNoneorSome(metadata_hash).More information here: https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#inclusion-in-an-extrinsic