Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libs and tools #2692

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Update libs and tools #2692

wants to merge 23 commits into from

Conversation

PhilippC
Copy link
Owner

@PhilippC PhilippC commented Oct 22, 2024

KP2A is using several older libraries and build tooling. This PR is about updating those at least partially.

== Build system updates ==

== Library updates ==

  • Updates okhttp to 4.12 (from 4.10.0-rc1)
  • Updates Dropbox to 5.4.6 (from 4.0.0). Note that upgrading to 7.0.0 was attempted but discarded. Binding the dropbox-android-sdk did not succeed. Anyway, this should fix [BUG] Cannot complete DropBox connection process #2436
  • Removes support for (very old) onedrive:// paths in KP2A. This is now no longer supported, but has been replaced with onedrive2:// a long time ago already. The old SDK is no longer available on maven and thus was removed from the build.
  • update Newtonsoft.Json, FluentFTP and MegaApiClient to the latest versions

PhilippC and others added 21 commits October 8, 2024 14:59
…onedrive:// is now no longer supported, but has been replaced with onedrive2:// a long time ago already.
Gradle v2 uses node16 which will be EOL soon.

"The only major breaking change from gradle-build-action@v2.12.0
is the update to require a Node 20 runtime environment.

Aside from that change, this release should generally serve as a
drop-in replacement for gradle-build-action@v2."

Gradle updated the action name, following the advice from
https://github.com/gradle/gradle-build-action/releases/tag/v3.0.0
v4 included breaking changes, but the setup here was compatible
thanks to the usage of `${{ github.job }}`.
https://github.com/actions/upload-artifact/releases/tag/v4.0.0

v3 artifact actions will be deprecated on November 30th
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

node16 actions will be EOL on October 15th
https://github.blog/changelog/2024-09-25-end-of-life-for-actions-node16/

These seem contradictory but I _guess_ on self-hosted runners one
can keep using v3 artifact actions until November 30th.
v3 is node20 and doesn't do validation by default like v4

validation can be disabled in v4 but when that bump is made it's
probably better to resolve the issues rather than ignore them.
…eded onedrive aar.

I wasn't successful in binding the latest dropbox sdk (7.0) and therefor only updated to 5.4.6 which doesn't require an .aar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot complete DropBox connection process
2 participants