Skip to content

Commit

Permalink
fix port trim
Browse files Browse the repository at this point in the history
  • Loading branch information
bobimicroweber committed Apr 26, 2024
1 parent b729869 commit ac2de6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions web/Modules/Docker/App/Models/DockerContainer.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ public static function boot()
$nextId = $getLastContainer->id + 1;
}

$model->port = trim($model->port);
$model->external_port = trim($model->external_port);

$dockerContainerApi = new DockerContainerApi();
$dockerContainerApi->setImage($model->image);
$dockerContainerApi->setEnvironmentVariables($model->environment_variables);
Expand Down
2 changes: 1 addition & 1 deletion web/app/Models/Domain.php
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ public function configureVirtualHost()
$findDockerContainer = DockerContainer::where('id', $this->server_application_settings['docker_container_id'])
->first();
if ($findDockerContainer) {
$apacheVirtualHostBuilder->setProxyPass('http://127.0.0.1:'.$findDockerContainer->external_port);
$apacheVirtualHostBuilder->setProxyPass('http://127.0.0.1:'.$findDockerContainer->external_port.'/');
$apacheVirtualHostBuilder->setAppType('docker');
$apacheVirtualHostBuilder->setAppVersion($appVersion);
}
Expand Down

0 comments on commit ac2de6c

Please sign in to comment.