Add secondary_raster_id parameter to run_detector

This enables running change detectors.

Also improved a bit the test helpers.

src/picterra/client.py

@@ -737,22 +737,26 @@ def delete_detector(self, detector_id: str):
         if not resp.ok:
             raise APIError(resp.text)
 
-    def run_detector(self, detector_id: str, raster_id: str) -> str:
+    def run_detector(
+        self, detector_id: str, raster_id: str, secondary_raster_id: str | None = None
+    ) -> str:
         """
         Runs a detector on a raster: predictions are subject to a minimum charge
         of 10 MP.
 
         Args:
             detector_id: The id of the detector
             raster_id: The id of the raster
+            secondary_raster_id: The id of the secondary raster. This needs to be provided to
+                run change detectors.
 
         Returns:
             operation_id: The id of the operation. You typically want to pass this
                 to `download_result_to_feature_collection`
         """
         resp = self.sess.post(
             self._api_url("detectors/%s/run/" % detector_id),
-            json={"raster_id": raster_id},
+            json={"raster_id": raster_id, "secondary_raster_id": secondary_raster_id},
         )
         if not resp.ok:
             raise APIError(resp.text)

tests/test_client.py

@@ -386,15 +386,20 @@ def add_mock_remote_import_responses(upload_id, post_body):
     )
 
 
-def add_mock_detector_run_responses(detector_id):
-    op_id = 43
-    _add_api_response("detectors/%s/run/" % detector_id, responses.POST, OP_RESP)
+def add_mock_detector_run_responses(detector_id, raster_id, secondary_raster_id=None):
+    _add_api_response(
+        "detectors/%s/run/" % detector_id, responses.POST, OP_RESP,
+        match=responses.matchers.json_params_matcher({
+            "raster_id": raster_id,
+            "secondary_raster_id": secondary_raster_id,
+        }),
+    )
     # First status check
     data = {"status": "running"}
-    _add_api_response("operations/%s/" % op_id, json=data)
+    _add_api_response("operations/%s/" % OPERATION_ID, json=data)
     # Second status check
     data = {"status": "success"}
-    _add_api_response("operations/%s/" % op_id, json=data)
+    _add_api_response("operations/%s/" % OPERATION_ID, json=data)
 
 
 def add_mock_vector_layer_responses(upload_id, raster_id, name, color):
@@ -895,11 +900,18 @@ def test_set_raster_detection_areas_from_file():
 
 @responses.activate
 def test_run_detector():
-    add_mock_detector_run_responses(1)
-    add_mock_operations_responses("success")
+    add_mock_detector_run_responses(1, 2)
     client = _client()
     client.run_detector(1, 2)
-    assert len(responses.calls) == 2
+    assert len(responses.calls) == 3
+
+
+@responses.activate
+def test_run_detector_secondary_raster():
+    add_mock_detector_run_responses(1, 2, 3)
+    client = _client()
+    client.run_detector(1, 2, 3)
+    assert len(responses.calls) == 3
 
 
 @responses.activate