Stop multiplying UV index in hourly forecast by 100 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloneofghosts
requested review from
cloneofghosts
and removed request for
alexander0042
cloneofghosts
approved these changes
Dec 4, 2023
|
Took a look at this and it looks good to merge, I'll get @alexander0042 to double check to make sure everything is in order and it can get merged. |
|
This is so great! Yes, you're 100% correct, it was a copy and paste error that got missed when I reviewed it. Thank you so much for not just identifying it, but also submitting a PR to fix it. Can't say enough how much I appreciate it, since PRs like this let me focus my work on improving the underlying API |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Also ensures rounding is to 2 decimal places, as the API seems to return data with that precision.
Have tested by tweaking HACS clone in local HA, and confirmed that the number looks more sensible and similar to other forecasts.