Fix Rounding #193
Merged
Fix Rounding #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know I could just add these commits to the main branch directly but I prefer doing it on a separate branch and merging it in so it can be included in the What's New Section of the automatically generated release notes. If you wanted to you can add branch protection rules which require pull requests before things get pushed to the main branch. You can also require reviews and status checks to pass before merging as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back in the rounding to sensors as per #192 since
suggested_display_precisionisn't supported by all cards. I added rounding to the sensors which weren't included before. Also updated it so that precipitation sensors have 4 decimal places by default and with rounding enabled 2 decimal places.The Lint workflow is failing because it's trying to commit formatting changes but can't. Due to the same issue that the GitHub issues are failing #150.