Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on blueprint #248

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Updates based on blueprint #248

merged 5 commits into from
Jun 17, 2024

Conversation

cloneofghosts
Copy link
Collaborator

@cloneofghosts cloneofghosts commented Jun 17, 2024

The other day I noticed that the blueprint this integration is based on has been updated so I updated this repository with the updated code. The updates mainly focused on the devcontainer but there were updates to the linting rules which I also fixed any errors relating to that. I tested on a devcontainer and everything is working as expected.

I was going to use the lint rules from the blueprint but they had everything enabled which seemed overkill so I'm using the rules that HA is using.

Fixes #246

@cloneofghosts
Copy link
Collaborator Author

I see that CodeQL caught the issue I mentioned in #246 in this PR (I changed the code slightly to fix lint error). Do we just dismiss it or change the line to not include their location?

@alexander0042
Copy link
Collaborator

Code checks are getting so good, that's pretty impressive! Also, thank you for updating to correspond to the blueprint, since it really helps to avoid major issues when changes are required.

Re: the lines, I think we just drop them from the logs. It's not particularly relevant for most debugging operations, and likely would be more useful to have the name anyway. I'll make that change to this branch and we can merge it as one

Remove debug logging to address updated blueprint
@cloneofghosts cloneofghosts merged commit 943af91 into master Jun 17, 2024
@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Jun 17, 2024

Everything is all merged in. There was a weird error where the lint changes didn't get committed but it seems to have sorted itself out.

Most of the updates from the blueprint will likely be to the devcontainer and will probably not change much of the integration itself.

@cloneofghosts cloneofghosts deleted the bluebrint-updates branch June 18, 2024 00:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Code scanning alert
2 participants