Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPNA-5915 exporter columns section #1091

Merged
merged 4 commits into from
Nov 8, 2023
Merged

PPNA-5915 exporter columns section #1091

merged 4 commits into from
Nov 8, 2023

Conversation

rafalmisiarek
Copy link
Contributor

@rafalmisiarek rafalmisiarek commented Nov 7, 2023 •
edited
Loading

Exporter columns section:

image

@rafalmisiarek rafalmisiarek requested review from a team, pulina and DareYouS and removed request for a team November 7, 2023 10:23
mrfijas
mrfijas reviewed Nov 8, 2023
View reviewed changes
custom_reports/columns.rst Show resolved Hide resolved
custom_reports/columns.rst Outdated Show resolved Hide resolved
conf.py Show resolved Hide resolved
mrfijas
mrfijas reviewed Nov 8, 2023
View reviewed changes
custom_reports/columns.rst Outdated Show resolved Hide resolved
pulina
pulina approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@pulina pulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section and we good to go

mrfijas
mrfijas approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@mrfijas mrfijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comment in https://github.com/PiwikPRO/PPMS-Analytics-Reporting/pull/2670#discussion_r1386405393

@rafalmisiarek rafalmisiarek merged commit 75893bf into 18.6 Nov 8, 2023
3 checks passed
@rafalmisiarek rafalmisiarek deleted the PPNA-5915-exporter-columns-section branch November 8, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kororokke kororokke kororokke approved these changes

@pulina pulina pulina approved these changes

@mrfijas mrfijas mrfijas approved these changes

@DareYouS DareYouS Awaiting requested review from DareYouS DareYouS was automatically assigned from PiwikPRO/backendisfine

@RomanSek RomanSek Awaiting requested review from RomanSek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafalmisiarek @mrfijas @pulina @kororokke