This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Bugfix: invalid mapping action entries in the new site #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undergrounder
changed the title
Undergrounder
changed the title
|
Hi @Undergrounder
Where could you see this bug in the tests? the build seems to pass, but maybe tests are not covering this use case? https://travis-ci.org/PiwikPRO/plugin-SiteMigration/jobs/81562722 - Maybe you could add some tests for it? |
|
Updated. It could be reproduced in the integration tests that follow up this change. I have now added some unit tests for this use case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the action entries are invalid on the new site, when the old id is -1, 0 or null.
It can be reproduced in the integration tests that folow up this change (It has no sense to merge failling integration tests...).
I have seen, that some tests have failed. I will try to fix them the next week.