Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traditional Chinese translation #392

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Conversation

ianiiaannn
Copy link
Contributor

@ianiiaannn ianiiaannn commented Jun 23, 2023

Fixed the formatting issues metioned in #54 by replace U+FF1A after replacing regular colon.
Screenshot 2023-06-24 012220
Screenshot 2023-06-24 012244
Screenshot 2023-06-24 012305

@flandretw
Copy link
Contributor

@ianiiaannn
I agree to this translation formatting correction. And can you help me change my name to flandretw? That's my new name, thank you very much.

@Intelli
Copy link
Contributor

Intelli commented Jul 17, 2023

The problem with replacing the colon with a separate space (": "), with the ":" character, is that the backend translation processing on the web server will then replace it with an ":" character... but then we'll be missing a space.

So ideally, we should just keep a standard colon. Rest of the changes should be fine though.

lang/zh-tw.yml Show resolved Hide resolved
@ianiiaannn ianiiaannn requested a review from Intelli July 19, 2023 10:03
@Intelli Intelli merged commit 4cce566 into PlayPro:master Jul 19, 2023
2 checks passed
U5B pushed a commit to U5B/CoreProtect that referenced this pull request Sep 22, 2023
* Update Phrase to make strings correctly split by fullwidth colons (U+FF1A)

* Fix Traditional Chinese translation

* Replace U+FF1A with `: `
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants