Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Stream Token Into Contracts #14

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Feature: Stream Token Into Contracts #14

merged 7 commits into from
Oct 9, 2023

Conversation

1yam
Copy link
Contributor

@1yam 1yam commented Oct 1, 2023

Description

Implement flow intro contracts

@1yam 1yam changed the title Feature: Stream Token Into Contractds Feature: Stream Token Into Contracts Oct 1, 2023
@1yam 1yam requested a review from LeTamanoir October 1, 2023 17:17
msg.sender
);

if (voteWeight == 0) {
if (voteWeight <= 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can it become negative ?

@@ -37,6 +37,31 @@ contract SuperfluidDaoToken is SuperTokenBase, SuperfluidAdmin {
_initialize(factory, name, symbol);
}

function createFlowIntoContract(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onlyAdmin needed

/// @dev This requires the contract to be a flowOperator for the msg sender.
/// @param token Token to stream.
/// @param flowRate Flow rate per second to stream.
function updateFlowIntoContract(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onlyAdmin needed


/// @notice Delete a stream that the msg.sender has open into the contract.
/// @param token Token to quit streaming.
function deleteFlowIntoContract(ISuperToken token) external {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onlyAdmin needed

@1yam 1yam merged commit 470f3e4 into main Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants