Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting flying robots from Bay. [IDB IGNORE] #8885

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Porting flying robots from Bay. [IDB IGNORE] #8885

merged 12 commits into from
Aug 1, 2023

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Jan 15, 2023 •
edited
Loading

  • Ports the flying robot mobtype from Bay along with some associated infrastructure (SSrobots).
  • Converts platforms to a buildable alt title of robot.
  • Ports robot module infrastructure from Bay to support the flying borg modules.
  • Ports Allowed_Spacemove() from Bay.
  • Removes the handy, glitterfly, drone and eyebot sprites from several of the base modules.
  • Adds flying subtypes of existing modules to use the removed icons.
  • Adds a unit test that validates all robot module icons.

Things to do:

  • Convert the existing modules to use the updated module infrastructure.
  • Make platforms buildable.
  • Add flying subtypes of existing modules.
  • Test and refine the spacemove changes.
  • Get the new unit test to pass.
  • Debug robot building so it stops dropping components on the floor.

@Atermonera Atermonera added Feature The PR adds new functionality in some way. Port [PR] This is code or assets from another codebase. Do Not Merge Generic DNM label. labels Jan 21, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the flyingborgs branch 2 times, most recently from 53eaa49 to 1195fd9 Compare March 16, 2023 03:55
@MistakeNot4892
Copy link
Contributor Author

CI fail looks unrelated.

@MistakeNot4892
Copy link
Contributor Author

This is more or less finished and ready for review but I will not be finishing it in the near future. Anyone wanting to pick it up and do the last parts (@Frenjo?) please feel free.

@MistakeNot4892
Copy link
Contributor Author

Reopening so I don't forget to finish it off.

@MistakeNot4892 MistakeNot4892 force-pushed the flyingborgs branch 8 times, most recently from 6712bc7 to 14fc6fe Compare July 20, 2023 14:12
@MistakeNot4892 MistakeNot4892 marked this pull request as ready for review July 20, 2023 14:17
@MistakeNot4892
Copy link
Contributor Author

I'm going to narrow scope on this one to just porting the Bay systems and integrating platforms. New modules and module rebalancing can happen down the track.

@MistakeNot4892 MistakeNot4892 force-pushed the flyingborgs branch 3 times, most recently from ae61971 to 023cc05 Compare July 20, 2023 17:13
@MistakeNot4892 MistakeNot4892 changed the title Porting flying robots from Bay. Porting flying robots from Bay. [IDB IGNORE] Jul 20, 2023
@MistakeNot4892
Copy link
Contributor Author

Slapping IDB ignore on here because I am expecting to need to push several times until the new unit test is happy.

@MistakeNot4892 MistakeNot4892 force-pushed the flyingborgs branch 4 times, most recently from a790082 to 69483f6 Compare July 20, 2023 19:01
@MistakeNot4892 MistakeNot4892 force-pushed the flyingborgs branch 4 times, most recently from 078518a to 5c95b95 Compare July 20, 2023 20:30
@MistakeNot4892
Copy link
Contributor Author

Ready to go once this is passing CI.

@Atermonera Atermonera removed the Do Not Merge Generic DNM label. label Jul 30, 2023
Atermonera
Atermonera reviewed Aug 1, 2023
View reviewed changes
code/game/machinery/machinery.dm Outdated Show resolved Hide resolved
code/game/objects/items/robot/robot_parts.dm Outdated Show resolved Hide resolved
code/modules/research/prosfab_designs.dm Outdated Show resolved Hide resolved
@Atermonera Atermonera merged commit 658e19e into PolarisSS13:master Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atermonera Atermonera Atermonera approved these changes

Assignees
No one assigned
Labels
Feature The PR adds new functionality in some way. Port [PR] This is code or assets from another codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @Atermonera