Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nunavut single status credit #430

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

runyao-yin
Copy link
Contributor

Fixes #391

Thanks for contributing! Please remove any top-level sections that do not apply to your changes.

  • make format && make documentation has been run.

New variable

  • Label field added
  • Documentation field added
  • Unit field added
  • Default value field added if relevant
  • Variable name follows conventions
  • Unit test(s) added
  • Integration test(s) added if relevant
  • Issues this PR fixes linked

What's changed

Description of the changes here.

Bug fix

  • Regression test added
  • Regression test passing

What this fixes and how it's fixed

Description of how this fix works goes here. Link any issues this PR fixes.

@PavelMakarchuk PavelMakarchuk self-requested a review August 9, 2023 01:34
@runyao-yin runyao-yin requested a review from MaxGhenis August 15, 2023 18:17
@PavelMakarchuk PavelMakarchuk removed the request for review from MaxGhenis August 15, 2023 23:23
runyao-yin and others added 5 commits August 15, 2023 19:50
…dits/single_status_credit/amount.yaml

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…dits/single_status_credit/amount.yaml

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
changelog_entry.yaml Outdated Show resolved Hide resolved
runyao-yin and others added 2 commits September 12, 2023 18:49
Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…its/single_status_credit/nu_single_status_credit_eligible.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
runyao-yin and others added 6 commits September 12, 2023 18:50
…its/single_status_credit/nu_single_status_credit.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…its/single_status_credit/nu_single_status_credit_eligible.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…its/single_status_credit/nu_single_status_credit.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…its/single_status_credit/nu_single_status_credit.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a make format and git pull upstream master

runyao-yin and others added 2 commits November 21, 2023 19:50
…its/single_status_credit/nu_single_status_credit_eligible.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…its/single_status_credit/nu_single_status_credit_eligible.py

Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
@PavelMakarchuk PavelMakarchuk removed their request for review November 27, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nunavut single status credit
3 participants