Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Improve phase transition points and fix instant-mode #298

Merged
merged 1 commit into from
May 16, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 15, 2024

What?

  • Fix instant-mode benchmarks
  • Improve dry-run-benches just command
  • Improve phase transition points

Why?

  • The calculation on the instantiator was inaccurate because the phase transition points were 1 block off
  • Just command can now run for a specific mode and runtime

How?

  • Now the start block of a state is the same block where on_initialize is called. Before it was the next block, even though the current one was still possible to call the extrinsics for that state

Testing?

just dry-run-benchmarks instant-mode

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 05-15-fix_instant-mode branch 2 times, most recently from 2ab1e08 to d0c57b1 Compare May 16, 2024 09:19
@JuaniRios JuaniRios changed the title fix instant-mode fix instant-mode May 16, 2024
@JuaniRios JuaniRios changed the title fix instant-mode ⚡️ Improve phase transition points and fix instant-mode May 16, 2024
@JuaniRios JuaniRios marked this pull request as ready for review May 16, 2024 09:23
Copy link

graphite-app bot commented May 16, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/16/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 16, 2024 10:23
pallets/funding/src/mock.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios merged commit 59e061b into main May 16, 2024
@JuaniRios JuaniRios deleted the 05-15-fix_instant-mode branch May 16, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants