Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Comprehensive funding end tests #303

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

JuaniRios
Copy link
Contributor

What?

Why?

How?

Testing?

Screenshots (optional)

Anything Else?

@JuaniRios JuaniRios mentioned this pull request May 22, 2024
Copy link
Contributor Author

JuaniRios commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@lrazovic lrazovic force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 6bab3a7 to 284add0 Compare May 22, 2024 13:14
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 284add0 to fe6bc90 Compare May 22, 2024 13:57
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 4cfc55a to a5e6fd9 Compare May 22, 2024 13:57
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from fe6bc90 to 7282303 Compare May 22, 2024 15:30
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from a5e6fd9 to 68f24eb Compare May 22, 2024 15:30
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 7282303 to e6e9eb2 Compare May 22, 2024 15:31
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch 4 times, most recently from 6d82e70 to b9119c2 Compare May 24, 2024 09:22
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from e6e9eb2 to 89d340a Compare May 24, 2024 09:42
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch 2 times, most recently from 34508c8 to c6646cc Compare May 24, 2024 11:44
@JuaniRios JuaniRios self-assigned this May 24, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 24, 2024 12:31
@JuaniRios JuaniRios marked this pull request as ready for review May 24, 2024 12:31
@JuaniRios JuaniRios changed the title Comprehensive funding end tests ✅ Comprehensive funding end tests May 24, 2024
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 89d340a to 9ef6bb5 Compare May 28, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from c6646cc to 49ac770 Compare May 28, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 9ef6bb5 to 9c072f8 Compare May 29, 2024 10:07
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 49ac770 to c16590e Compare May 29, 2024 10:08
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 9c072f8 to a6e7c78 Compare May 29, 2024 11:29
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from c16590e to 10e938a Compare May 29, 2024 11:29
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from a6e7c78 to f08750f Compare May 29, 2024 12:01
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 10e938a to 5d12e2f Compare May 29, 2024 12:01
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from f08750f to 254e6de Compare May 29, 2024 12:26
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 5d12e2f to 089dd93 Compare May 29, 2024 12:26
@JuaniRios JuaniRios force-pushed the 05-22-double-check_evaluation_reward_benchmarks branch from 254e6de to 7b32f16 Compare May 29, 2024 12:28
Base automatically changed from 05-22-double-check_evaluation_reward_benchmarks to main May 29, 2024 12:29
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 089dd93 to b022520 Compare May 29, 2024 12:42
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from b022520 to 0166950 Compare May 31, 2024 09:36
@lrazovic lrazovic changed the title ✅ Comprehensive funding end tests 🔧 Add Funding and Dispenser weights Jun 3, 2024
@lrazovic lrazovic changed the title 🔧 Add Funding and Dispenser weights ✅ Comprehensive funding end tests Jun 3, 2024
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

LGTM - Let's address the warnings and few nits (that we can discuss if needed) and then we can merge

integration-tests/src/tests/e2e.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/6_funding_end.rs Outdated Show resolved Hide resolved
pallets/funding/src/functions/5_funding_end.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 0166950 to 0980858 Compare June 3, 2024 13:23
@JuaniRios JuaniRios requested a review from lrazovic June 3, 2024 13:25
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 0980858 to 94159d0 Compare June 3, 2024 14:15
@JuaniRios JuaniRios force-pushed the 05-22-comprehensive_funding_end_tests branch from 94159d0 to fe2d5dd Compare June 3, 2024 14:41
@JuaniRios JuaniRios merged commit 079940c into main Jun 3, 2024
@JuaniRios JuaniRios deleted the 05-22-comprehensive_funding_end_tests branch June 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants