Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Test freeze restrictions on bids #307

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 27, 2024

What?

  • Test what happens when you bid with frozen balance, i.e. a hold on a freeze.

Why?

  • To double-check our assumptions about these interactions

How?

  • An bidder holds ED + an amount frozen.
  • It uses that frozen amount to bid
  • The project fails / succeeds
  • If it fails, he gets the PLMC back, if it succeeds, he waits and then vests the full amount.
  • In the end, the user still has the freeze restriction

Testing?

can_bid_with_frozen_tokens_funding_success and can_bid_with_frozen_tokens_funding_failed

Anything Else?

Next PRs will do the same for other participation types

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 228e327 to 93443f9 Compare May 27, 2024 11:37
@JuaniRios JuaniRios changed the title test-freeze-bid-interaction ✅ Test freeze restrictions on bids May 27, 2024
@JuaniRios JuaniRios marked this pull request as ready for review May 27, 2024 11:41
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 27, 2024 11:41
Copy link

graphite-app bot commented May 27, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/27/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from a00d687 to ecf2c60 Compare May 27, 2024 14:02
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 93443f9 to a800872 Compare May 27, 2024 14:02
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from ecf2c60 to f8b042c Compare May 27, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from a800872 to 7d84d82 Compare May 27, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from f8b042c to 4a469c2 Compare May 27, 2024 14:46
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 7d84d82 to 4b5c2cd Compare May 27, 2024 14:46
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 4a469c2 to d72b49f Compare May 27, 2024 14:57
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 4b5c2cd to 64a1977 Compare May 27, 2024 14:57
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from d72b49f to 2fd204f Compare May 28, 2024 11:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 64a1977 to acbfaea Compare May 28, 2024 11:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 2fd204f to 1bf52b2 Compare May 28, 2024 12:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from acbfaea to 6b94e27 Compare May 28, 2024 12:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 1bf52b2 to ca9672e Compare May 28, 2024 13:55
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 6b94e27 to 3b45aa7 Compare May 28, 2024 13:55
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from ca9672e to d010614 Compare May 28, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 3b45aa7 to d70b337 Compare May 28, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 81fbfc9 to a13bfd2 Compare May 31, 2024 09:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from eda63fd to 13a9218 Compare May 31, 2024 09:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from a13bfd2 to 71923ad Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 13a9218 to dd3e1e8 Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 71923ad to 1c5a8af Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from dd3e1e8 to 64a77be Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 1c5a8af to 6fef773 Compare June 4, 2024 09:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 64a77be to a63b0e7 Compare June 4, 2024 09:32
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments as the Evaluation PR

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 6fef773 to d15ed73 Compare June 11, 2024 08:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from a63b0e7 to db3191d Compare June 11, 2024 08:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from d15ed73 to 4542022 Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from db3191d to fbd1cd0 Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 4542022 to 3fbb8de Compare June 11, 2024 10:25
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch 2 times, most recently from 9dc37c1 to 49857a2 Compare June 11, 2024 10:48
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 3fbb8de to 8156ac3 Compare June 11, 2024 10:49
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 49857a2 to 1ca1e36 Compare June 11, 2024 10:50
@JuaniRios JuaniRios requested a review from vstam1 June 11, 2024 10:54
Copy link
Contributor Author

JuaniRios commented Jun 11, 2024

Merge activity

  • Jun 11, 10:37 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Jun 11, 10:40 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 11, 10:41 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-interactions branch from 8156ac3 to 6e44825 Compare June 11, 2024 14:37
Base automatically changed from 05-27-test-freeze-interactions to main June 11, 2024 14:39
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 1ca1e36 to cfc4bea Compare June 11, 2024 14:40
@JuaniRios JuaniRios merged commit 6775ef7 into main Jun 11, 2024
@JuaniRios JuaniRios deleted the 05-27-test-freeze-bid-interaction branch June 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants