Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Test freeze restrictions on contributions #308

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 27, 2024

What?

  • Test what happens when you contribute (community/remainder) with frozen balance, i.e. a hold on a freeze.

Why?

  • To double-check our assumptions about these interactions

How?

  • An contributor holds ED + an amount frozen.
  • It uses that frozen amount to contribute
  • The project fails / succeeds
  • If it fails, he gets the PLMC back, if it succeeds, he waits and then vests the full amount.
  • In the end, the user still has the freeze restriction

Testing?

can_contribute_with_frozen_tokens_funding_success and can_contribute_with_frozen_tokens_funding_failed

@JuaniRios JuaniRios changed the title test-freeze-contribution-interaction ✅ Test freeze restrictions on contributions May 27, 2024
@JuaniRios JuaniRios self-assigned this May 27, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 27, 2024 12:42
@JuaniRios JuaniRios marked this pull request as ready for review May 27, 2024 12:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 93443f9 to a800872 Compare May 27, 2024 14:02
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 9ba16be to 79f6397 Compare May 27, 2024 14:02
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from a800872 to 7d84d82 Compare May 27, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 79f6397 to a427baa Compare May 27, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 7d84d82 to 4b5c2cd Compare May 27, 2024 14:46
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from a427baa to 2e9f80c Compare May 27, 2024 14:46
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 4b5c2cd to 64a1977 Compare May 27, 2024 14:57
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 2e9f80c to f191f84 Compare May 27, 2024 14:57
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 64a1977 to acbfaea Compare May 28, 2024 11:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from f191f84 to 1a8aa9c Compare May 28, 2024 11:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from acbfaea to 6b94e27 Compare May 28, 2024 12:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 1a8aa9c to ff0172f Compare May 28, 2024 12:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 6b94e27 to 3b45aa7 Compare May 28, 2024 13:55
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from ff0172f to 487a932 Compare May 28, 2024 13:55
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 3b45aa7 to d70b337 Compare May 28, 2024 14:35
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 487a932 to 5a42e55 Compare May 28, 2024 14:36
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from d70b337 to 232e641 Compare May 29, 2024 10:08
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 5a42e55 to 5b08291 Compare May 29, 2024 10:08
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 13a9218 to dd3e1e8 Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 5e03703 to c2734e9 Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from dd3e1e8 to 64a77be Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from c2734e9 to 00658aa Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 64a77be to a63b0e7 Compare June 4, 2024 09:32
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 00658aa to 816e301 Compare June 4, 2024 09:32
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments as Evaluation PR

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from a63b0e7 to db3191d Compare June 11, 2024 08:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 816e301 to 5a10755 Compare June 11, 2024 08:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from db3191d to fbd1cd0 Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 5a10755 to 458cb00 Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from fbd1cd0 to 9dc37c1 Compare June 11, 2024 10:25
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 458cb00 to 7bcbf6d Compare June 11, 2024 10:25
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 9dc37c1 to 49857a2 Compare June 11, 2024 10:48
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 7bcbf6d to 27538ee Compare June 11, 2024 10:48
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 49857a2 to 1ca1e36 Compare June 11, 2024 10:50
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch 2 times, most recently from 80fbb7f to a3c2e3d Compare June 11, 2024 10:54
@JuaniRios JuaniRios requested a review from vstam1 June 11, 2024 10:54
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-bid-interaction branch from 1ca1e36 to cfc4bea Compare June 11, 2024 14:40
Base automatically changed from 05-27-test-freeze-bid-interaction to main June 11, 2024 14:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from a3c2e3d to 1c59fc6 Compare June 11, 2024 14:43
Copy link
Contributor Author

JuaniRios commented Jun 11, 2024

Merge activity

@JuaniRios JuaniRios merged commit 8fcf294 into main Jun 11, 2024
@JuaniRios JuaniRios deleted the 05-27-test-freeze-contribution-interaction branch June 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants