🗑️ Scrap Async Instantiation

[JuaniRios]

What?

• Remove async instantiation

Why?

• Tried making genesis parallel instantiation work, but after the SDK update it seems it's no longer possible due to features like "std" not being passed when calling the runtime for the genesis raw spec creation.
• It is used only in a few tests, and so it's better to delete it all to avoid maintaining it.

How?

• Delete the async file
• Modify tests that used it
• Remove the populated chain spec

[JuaniRios]

• 🗑️ Scrap Async Instantiation #310 👈
• ✅ Test freeze restrictions on contributions #308 : 2 other dependent PRs (#311 , #312 )
• ✅ Test freeze restrictions on bids #307
• ✅ Test freeze restrictions on evaluations #306
• ✅ Comprehensive settlement tests #304
• ✅ Comprehensive funding end tests #303 : 1 other dependent PR (#315 )
• 🕵🏻 Double-check evaluation reward benchmarks #302
• 💀 New Benchmarks #301
• ✨ Optimize wap calculation #299 : 1 other dependent PR (#300 )
• 🎨 Restructure funding functions file #296
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite

[vstam1]

Love every piece of code simplification! I was wondering about the whole RefCell setup. I can vaguely remember that it was needed for the Async feature with different execution environments? I was wondering if we could change this RefCell implementation now, as we do not require the std execution environment anymore? I might be completely mistaken, but just a general question.

[JuaniRios]

Love every piece of code simplification! I was wondering about the whole RefCell setup. I can vaguely remember that it was needed for the Async feature with different execution environments? I was wondering if we could change this RefCell implementation now, as we do not require the std execution environment anymore? I might be completely mistaken, but just a general question.

RefCell is there for tests, since we need to setup the mock externalities manually. We use "std" because is needed in both tests and benchmark tests, but cannot be included in the wasm runtime