Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix storage migration #316

Merged
merged 1 commit into from
Jun 5, 2024
Merged

🔧 Fix storage migration #316

merged 1 commit into from
Jun 5, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 5, 2024

What?

  • Fix a bug in the storage migration of pallet funding from 2->3

Why?

  • ProjectStatus was wrongly migrated inside ProjectDetails

How?

  • We added a new status CalculatingWap which changed the indices of all enums when encoded, which we forgot to account for

Testing?

Tested by forking Polkadot and Polimec with chopsticks using npx @acala-network/chopsticks@latest xcm -r polkadot -p scripts/chopsticks/polimec-testing/polkadot-polimec.yml

Anything Else?

The new chopsticks script replaces the Council and TC with test accounts, which means we can quickly do sudo operations

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title fix storage migration Fix storage migration Jun 5, 2024
@JuaniRios JuaniRios changed the title Fix storage migration 🔧 Fix storage migration Jun 5, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 5, 2024 12:59
Copy link

graphite-app bot commented Jun 5, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (06/05/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 06-05-fix_storage_migration branch from 91b29c8 to ccfcdfd Compare June 5, 2024 13:10
@JuaniRios JuaniRios force-pushed the 06-05-fix_storage_migration branch from ccfcdfd to 40a8849 Compare June 5, 2024 13:13
@lrazovic lrazovic self-requested a review June 5, 2024 15:05
@JuaniRios JuaniRios merged commit 1ed8993 into main Jun 5, 2024
@JuaniRios JuaniRios deleted the 06-05-fix_storage_migration branch June 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants