Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Start failed evaluation settlement #331

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 20, 2024

What?

  • Schedule the start of settlement for a failed evaluation round
  • Settlement functions now check that the settlement was started, and the round is correct (with new more descriptive errors)

Why?

  • We forgor 💀

Testing?

Refactored some tests to adapt to the new logic

Anything Else?

We need to re-benchmark end_evaluation_failure since it has a new parameter. For now the parameter is added but not used

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title Start failed evaluation settlement 🐛 Start failed evaluation settlement Jun 20, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 20, 2024 11:43
Copy link

graphite-app bot commented Jun 20, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (06/20/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 06-20-start_failed_evaluation_settlement branch from 474b8d6 to a7b537a Compare June 20, 2024 11:53
@JuaniRios JuaniRios merged commit 86996b7 into main Jun 21, 2024
@JuaniRios JuaniRios deleted the 06-20-start_failed_evaluation_settlement branch June 21, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants