Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚮 Remove politest #334

Merged
merged 1 commit into from
Jun 25, 2024
Merged

🚮 Remove politest #334

merged 1 commit into from
Jun 25, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 24, 2024 •
edited
Loading

What?

  • Remove the politest runtime

Why?

  • We already have funding pallet on polimec, and everything else can be feature-gated
  • We can anyway run extrinsics with root when using chopsticks

How?

  • Delete all references to politest
  • Make sure we can have test credentials with "development-settings" feature, and fast rounds with "fast-mode"

Testing?

  • cargo test --features runtime-benchmarks
  • cargo test -p integration-tests
  • just dry-run-benchmarks

This was referenced Jun 24, 2024
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jun 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

Base automatically changed from 06-19-test_migration_with_zombienet to main June 24, 2024 11:31
@JuaniRios JuaniRios force-pushed the 06-24-remove_politest branch 2 times, most recently from 368bf75 to 866bdb4 Compare June 24, 2024 12:20
@JuaniRios JuaniRios changed the title remove politest 🚮 Remove politest Jun 24, 2024
@JuaniRios JuaniRios self-assigned this Jun 24, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 24, 2024 12:33
@JuaniRios JuaniRios mentioned this pull request Jun 24, 2024
Merged
vstam1
vstam1 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comments

nodes/parachain/src/command.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios merged commit 1edc79b into main Jun 25, 2024
@JuaniRios JuaniRios deleted the 06-24-remove_politest branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @vstam1