Set migration user to Multilocation #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on |
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (06/25/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
vstam1
reviewed
Jun 25, 2024
There was a problem hiding this comment.
I think it looks good in general. Only thing I'm thinking about is how to work with the different xcm versions. XCMv4 is of course now created, and I think most of the XCM types have changed a bit (not sure about their encoding though). But if we are storing them as XCMv3 now, we might need to do a migration when we move to XCMv4 (or 5)
|
@vstam1 good point, but I think the migration should be fairly trivial no? |
JuaniRios
force-pushed
the
06-25-set_migration_user_to_multilocation
branch
from
b122521
to
1b1c897
Compare
JuaniRios
force-pushed
the
06-25-set_migration_user_to_multilocation
branch
from
1b1c897
to
3f99a8f
Compare
vstam1
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
userfield of a migration item to aMultiLocationinstead of a[u8; 32]Why?
So we can handle more account types, like Ethereum with
AccountId20How?
For now we hardcode the migrations with
Multilocation(0, X1(AccountId32))