Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Run new benchmarks #352

Merged
merged 1 commit into from
Jul 8, 2024
Merged

💻 Run new benchmarks #352

merged 1 commit into from
Jul 8, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 5, 2024

What?

  • Run the added benchmarks on AWS and put them on the pallet and runtime weight files
  • hrmp benches ended up being lower than assumed XCM constant, so we're safe there.

How?

  • Created a new just file to benchmark only certain extrinsics called benchmark-extrinsics

Anything Else?

  • I saw that the only difference between the pallet and runtime benchmark configurations in our just-file are the flags
--no-storage-info \
--no-median-slopes \
--no-min-squares \

And those ones only seem to be affecting the print to console and not the actual benchmarking, so I copy-pasted the generated weights to both the pallet and runtime files

Copy link
Contributor Author

JuaniRios commented Jul 5, 2024

@JuaniRios JuaniRios force-pushed the 07-05-experiment_hrmp_weighing branch from 01b27d8 to 8d16a3e Compare July 5, 2024 15:55
@JuaniRios JuaniRios force-pushed the 07-05-run_new_benchmarks branch 2 times, most recently from 7183083 to 9baa346 Compare July 5, 2024 15:59
@JuaniRios JuaniRios changed the title run new benchmarks 💻 Run new benchmarks Jul 5, 2024
@JuaniRios JuaniRios marked this pull request as ready for review July 5, 2024 16:05
@JuaniRios JuaniRios requested review from lrazovic and vstam1 July 5, 2024 16:05
Copy link

graphite-app bot commented Jul 5, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (07/05/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly skimmed the weights, and they look good. Only question I still have is around this do_handle_channel_* benchmarks. I'm not sure if it would work like this.

@JuaniRios
Copy link
Contributor Author

@vstam1

not sure if it would work like this.

Could you elaborate more what you meant?

@JuaniRios JuaniRios force-pushed the 07-05-experiment_hrmp_weighing branch from 8d16a3e to d7ce482 Compare July 8, 2024 10:35
@JuaniRios JuaniRios requested a review from vstam1 July 8, 2024 10:36
@JuaniRios JuaniRios force-pushed the 07-05-experiment_hrmp_weighing branch from d7ce482 to 3ec59c1 Compare July 8, 2024 10:39
Copy link
Collaborator

vstam1 commented Jul 8, 2024

Related to the question in the prev PR. Can continue 'discussion' there

@JuaniRios JuaniRios force-pushed the 07-05-experiment_hrmp_weighing branch from 3ec59c1 to bcebb39 Compare July 8, 2024 11:16
@JuaniRios JuaniRios force-pushed the 07-05-run_new_benchmarks branch 3 times, most recently from 2f29ffe to cfa3351 Compare July 8, 2024 11:42
Copy link
Contributor Author

JuaniRios commented Jul 8, 2024

Merge activity

  • Jul 8, 8:35 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Jul 8, 8:44 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 8, 8:45 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios force-pushed the 07-05-experiment_hrmp_weighing branch from bcebb39 to 804dae0 Compare July 8, 2024 12:40
Base automatically changed from 07-05-experiment_hrmp_weighing to main July 8, 2024 12:43
@JuaniRios JuaniRios merged commit 7d2349a into main Jul 8, 2024
@JuaniRios JuaniRios deleted the 07-05-run_new_benchmarks branch July 8, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants