Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✲ Transitions can be called by anyone #362

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 22, 2024

What?

  • Root transition functions can now be called by anyone

Why?

  • We no longer have automatic transitions
  • Our transition logic already checks if a transition is supposed to happen or not, so no reason to gate it behind root
  • This should be called automatically through an offchain script of OCW

How?

  • changed ensure_root to ensure_signed + some naming changes

Testing?

In a later PR

@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
27 tasks
Copy link
Contributor Author

JuaniRios commented Jul 22, 2024

@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from d311843 to 32134be Compare July 22, 2024 11:47
@JuaniRios JuaniRios changed the title simplifications part 2 Transitions can be called by anyone Jul 22, 2024
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 32134be to cd892f3 Compare July 22, 2024 12:14
@JuaniRios JuaniRios changed the title Transitions can be called by anyone ✲ Transitions can be called by anyone Jul 22, 2024
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from cd892f3 to 3e4fb18 Compare July 22, 2024 14:33
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 3e4fb18 to 9bba0d9 Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 9bba0d9 to 43f19cf Compare July 22, 2024 15:03
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to reindex everything again? Can't we just leave the single index out? So indices go from 1,2,3, 5,6,7

Copy link
Contributor Author

Do we have to reindex everything again? Can't we just leave the single index out? So indices go from 1,2,3, 5,6,7

We don't have anything relying on indexes as of now. Once we do we can try avoiding updating them

@JuaniRios JuaniRios marked this pull request as ready for review August 5, 2024 14:50
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:01 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:02 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-22-additional_changes to graphite-base/362 August 23, 2024 09:57
@JuaniRios JuaniRios changed the base branch from graphite-base/362 to main August 23, 2024 09:59
@JuaniRios JuaniRios merged commit 4c23429 into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-22-simplifications_part_2 branch August 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants