Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚮 Remove "Y" variable from fee allocation #363

Merged
merged 1 commit into from
Aug 23, 2024
Merged

🚮 Remove "Y" variable from fee allocation #363

merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 22, 2024 •
edited
Loading

What?

  • Remove the Y variable (percent usd reached from target)

Why?

  • Unnecessary complexity

How?

  • Evaluator rewards are always 30% of fee CTs, LTHB always 20% when evaluator rewards are given

Testing?

Not yet

This was referenced Jul 22, 2024
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jul 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios changed the title simplifications part 3 Remove "Y" variable from fee allocation Jul 22, 2024
@JuaniRios JuaniRios marked this pull request as ready for review July 22, 2024 12:16
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 22, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (07/22/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios marked this pull request as draft July 22, 2024 12:21
@JuaniRios JuaniRios changed the title Remove "Y" variable from fee allocation 🚮 Remove "Y" variable from fee allocation Jul 22, 2024
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from cd892f3 to 3e4fb18 Compare July 22, 2024 14:33
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from c590033 to 447b78a Compare July 22, 2024 14:33
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 3e4fb18 to 9bba0d9 Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from 447b78a to fe0f499 Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 9bba0d9 to 43f19cf Compare July 22, 2024 15:03
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from fe0f499 to 67bf472 Compare July 22, 2024 15:03
This was referenced Jul 26, 2024
Merged
Merged
vstam1
vstam1 requested changes Aug 2, 2024
View reviewed changes
pallets/funding/src/functions/misc.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 43f19cf to 3c4bc58 Compare August 5, 2024 09:45
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch 2 times, most recently from c2065c1 to 2a73180 Compare August 5, 2024 10:17
This was referenced Aug 5, 2024
Merged
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_2 branch from 3c4bc58 to 4841675 Compare August 5, 2024 14:35
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from 2a73180 to 67d55e8 Compare August 5, 2024 14:35
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
Closed
This was referenced Aug 6, 2024
Merged
Merged
Merged
Merged
Closed
This was referenced Aug 9, 2024
Merged
Merged
This was referenced Aug 13, 2024
Closed
Closed
Merged
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_2 branch from 5cac611 to 6330909 Compare August 16, 2024 13:03
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_3 branch from 64243b0 to 5f28258 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
Closed
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_2 branch from 5cac611 to 6330909 Compare August 16, 2024 13:13
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_3 branch from 64243b0 to 5f28258 Compare August 16, 2024 13:13
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024 •
edited
Loading

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:04 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:05 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-22-simplifications_part_2 to graphite-base/363 August 23, 2024 10:00
@JuaniRios JuaniRios changed the base branch from graphite-base/363 to main August 23, 2024 10:02
@JuaniRios JuaniRios merged commit 8b2ca41 into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-22-simplifications_part_3 branch August 23, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1