Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New evaluation reward/slash thresholds #366

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 26, 2024

What?

  • There is now only one threshold configurable at runtime. Above the project is successful and evaluators rewarded, below project fails and evaluators slashed. No issuer decision

Why?

  • Simplifies logic greatly

Testing?

  • Commented out all tests for now. Will be fixed in a later PR

@JuaniRios JuaniRios changed the title Simplifications part 5 New evaluation reward/slash thresholds Jul 26, 2024
@JuaniRios JuaniRios changed the title New evaluation reward/slash thresholds ✨ New evaluation reward/slash thresholds Jul 26, 2024
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch 7 times, most recently from a09d875 to 0f61954 Compare July 30, 2024 10:53
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0f61954 to 0e334fa Compare July 30, 2024 11:28
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 5d4ca77 to 5e21667 Compare August 5, 2024 09:46
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0e334fa to 291cb86 Compare August 5, 2024 09:46
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 5e21667 to 0069666 Compare August 5, 2024 10:06
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch 2 times, most recently from f1168a6 to 0101bb2 Compare August 5, 2024 10:08
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 0069666 to b1d13b0 Compare August 5, 2024 10:17
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0101bb2 to a498df9 Compare August 5, 2024 10:17
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from b1d13b0 to 377f267 Compare August 5, 2024 10:33
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from a498df9 to 7b27530 Compare August 5, 2024 10:33
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from f89881e to 3219bc8 Compare August 6, 2024 09:30
@JuaniRios JuaniRios changed the base branch from 08-05-comment-out-tests to 07-22-simplifications_part_4 August 6, 2024 09:30
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_4 branch from ec5fc28 to d353b87 Compare August 16, 2024 13:03
@lrazovic lrazovic force-pushed the 07-26-simplifications_part_5 branch from 494a503 to 52e7d53 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_4 branch from ec5fc28 to d353b87 Compare August 16, 2024 13:13
@lrazovic lrazovic force-pushed the 07-26-simplifications_part_5 branch from 494a503 to 52e7d53 Compare August 16, 2024 13:13
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:10 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:11 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-22-simplifications_part_4 to graphite-base/366 August 23, 2024 10:06
@JuaniRios JuaniRios changed the base branch from graphite-base/366 to main August 23, 2024 10:08
@JuaniRios JuaniRios merged commit feaa7f8 into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-26-simplifications_part_5 branch August 23, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants