Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✌️ Fix project transition event #368

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 5, 2024

What?

  • We now emit project transition events
  • We do it in the transition project function
  • We now use the transition project function for every transition (before was used only till community round)

How?

  • We now use the same project status enum in the event as in the project details
  • Events are emitted in the transition project function only
  • Transition function is now always used when changing the project state in project_details

Testing?

  • project_state_transition_event

@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 1b261e9 to 7a3afd5 Compare August 5, 2024 10:49
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 7a3afd5 to 14eb537 Compare August 5, 2024 11:57
@JuaniRios JuaniRios self-assigned this Aug 5, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch 2 times, most recently from b224570 to 50ccc77 Compare August 5, 2024 14:13
@JuaniRios JuaniRios changed the title Fix project transition event ✌️ Fix project transition event Aug 5, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 50ccc77 to e2f1a55 Compare August 5, 2024 14:36
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from e2f1a55 to cf5e7ff Compare August 5, 2024 14:40
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from cf5e7ff to 0364aa1 Compare August 5, 2024 14:42
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0364aa1 to cc9f647 Compare August 5, 2024 14:49
@JuaniRios JuaniRios marked this pull request as ready for review August 5, 2024 14:51
@JuaniRios JuaniRios requested a review from lrazovic August 5, 2024 14:52
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Can we now remove the ProjectPhase enum from types? I think it was only being used in the ProjectPhaseTransition enum.

@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 16913f6 to 780a65d Compare August 13, 2024 09:04
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 780a65d to ccec8a8 Compare August 13, 2024 09:27
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from ccec8a8 to 6f6ac57 Compare August 13, 2024 09:38
This was referenced Aug 13, 2024
@lrazovic lrazovic force-pushed the 08-05-fix_project_transition_event branch from 6f6ac57 to 0712fc1 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0712fc1 to 6f6ac57 Compare August 16, 2024 13:09
@lrazovic lrazovic force-pushed the 08-05-fix_project_transition_event branch from 6f6ac57 to 0712fc1 Compare August 16, 2024 13:13
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0712fc1 to 6f6ac57 Compare August 22, 2024 12:57
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:22 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:23 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-22-fix_existing_tests to graphite-base/368 August 23, 2024 10:15
@JuaniRios JuaniRios changed the base branch from graphite-base/368 to main August 23, 2024 10:19
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 6f6ac57 to f4e14ba Compare August 23, 2024 10:21
@JuaniRios JuaniRios merged commit 02e23fd into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-05-fix_project_transition_event branch August 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants