Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove AuctionInitializePeriod #377

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 9, 2024

What?

  • Remove the AuctionInitializePeriod
  • As soon as the evaluation ends, if successful, the auction starts

Why?

  • So we have a deterministic end of the Funding Round.

How?

  • Remove start_auction extrinsic (it was only setting the project status)
  • In the end_auction extrinsic, on success, instead of setting the status to AuctionInitializePeriod, set it to AuctionRound

Testing?

  • If previous tests work, then its fine

@JuaniRios JuaniRios force-pushed the 08-09-remove_auctioninitializeperiod branch from 275751b to 8def483 Compare August 9, 2024 11:41
@JuaniRios JuaniRios changed the title remove AuctionInitializePeriod 💥 Remove AuctionInitializePeriod Aug 9, 2024
@JuaniRios JuaniRios self-assigned this Aug 9, 2024
@JuaniRios JuaniRios marked this pull request as ready for review August 9, 2024 11:43
@JuaniRios JuaniRios force-pushed the 08-09-remove_auctioninitializeperiod branch from 8def483 to aa77143 Compare August 13, 2024 09:04
@JuaniRios JuaniRios force-pushed the 08-09-remove_auctioninitializeperiod branch from aa77143 to deac748 Compare August 13, 2024 09:27
@JuaniRios JuaniRios force-pushed the 08-09-remove_auctioninitializeperiod branch from deac748 to 44ce271 Compare August 13, 2024 09:39
This was referenced Aug 13, 2024
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:42 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:43 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 08-06-new_tests to graphite-base/377 August 23, 2024 10:36
@JuaniRios JuaniRios changed the base branch from graphite-base/377 to main August 23, 2024 10:39
@JuaniRios JuaniRios force-pushed the 08-09-remove_auctioninitializeperiod branch from e26d80c to 39649ec Compare August 23, 2024 10:41
@JuaniRios JuaniRios merged commit cf121bb into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-09-remove_auctioninitializeperiod branch August 23, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants